Skip to content

bugfix: set progressbar width to 0 manually, pterm will use terminal width #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 22, 2022
Merged

bugfix: set progressbar width to 0 manually, pterm will use terminal width #128

merged 1 commit into from
Aug 22, 2022

Conversation

howieyuen
Copy link
Collaborator

@howieyuen howieyuen commented Aug 19, 2022 •
edited
Loading

fix #129

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2887427415

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 74.244%
Totals Coverage Status
Change from base Build 2882136835: 0.05%
Covered Lines: 4321
Relevant Lines: 5820
💛 - Coveralls

@howieyuen howieyuen enabled auto-merge (squash) August 19, 2022 06:16
@howieyuen howieyuen self-assigned this Aug 19, 2022
@howieyuen howieyuen added the cli label Aug 19, 2022
@howieyuen howieyuen added this to the v0.7.0 milestone Aug 19, 2022
elliotxx
elliotxx approved these changes Aug 19, 2022
View reviewed changes
Copy link
Contributor

@elliotxx elliotxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

markliby
markliby approved these changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@markliby markliby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@howieyuen howieyuen merged commit 7922980 into KusionStack:main Aug 22, 2022
@howieyuen howieyuen deleted the bugfix-pb-width branch August 22, 2022 03:07
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elliotxx elliotxx elliotxx approved these changes

+1 more reviewer

@markliby markliby markliby approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@howieyuen howieyuen

Labels
None yet
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.

kusion apply progressbar display wiredly
4 participants
@howieyuen @coveralls @elliotxx @markliby