Skip to content

feat: add watch step to monitor resource changes for kusion apply #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 27, 2022
Merged

feat: add watch step to monitor resource changes for kusion apply #125

merged 2 commits into from
Sep 27, 2022

Conversation

howieyuen
Copy link
Collaborator

@howieyuen howieyuen commented Aug 12, 2022 •
edited
Loading

related: #23

preview:
image

@howieyuen howieyuen added kind/feature Categorizes issue or PR as related to a new feature cli labels Aug 12, 2022
@howieyuen howieyuen added this to the v0.6.0 milestone Aug 12, 2022
@howieyuen howieyuen changed the title feat: add watch cmd to monitor resource changes by runtime [WIP]feat: add watch cmd to monitor resource changes by runtime Aug 12, 2022
@howieyuen howieyuen self-assigned this Aug 12, 2022
@coveralls
Copy link

coveralls commented Aug 12, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3127971705

  • 91 of 160 (56.88%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 73.804%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/kusionctl/cmd/apply/options.go 1 28 3.57%
pkg/engine/operation/watch.go 87 129 67.44%
Totals Coverage Status
Change from base Build 3127452548: -0.3%
Covered Lines: 4522
Relevant Lines: 6127
💛 - Coveralls

@howieyuen howieyuen changed the title [WIP]feat: add watch cmd to monitor resource changes by runtime [PoC]feat: add watch cmd to monitor resource changes by runtime Aug 16, 2022
@howieyuen howieyuen force-pushed the kusion-watch branch 2 times, most recently from 8d83787 to 1a14945 Compare August 29, 2022 11:34
@howieyuen howieyuen changed the title [PoC]feat: add watch cmd to monitor resource changes by runtime feat: add watch step to monitor resource changes for kusion apply Aug 29, 2022
@howieyuen howieyuen enabled auto-merge (squash) August 29, 2022 11:42
@howieyuen howieyuen disabled auto-merge August 29, 2022 11:42
@howieyuen howieyuen modified the milestones: v0.6.0, v0.7.0 Aug 29, 2022
@howieyuen
Copy link
Collaborator Author

updated: refactor k8s printer structure

@howieyuen howieyuen force-pushed the kusion-watch branch 4 times, most recently from 6de3756 to b155a5a Compare September 13, 2022 08:24
@howieyuen
feat: add watch step for kusion apply
d345fdf 
- '-w' flag can control it on or off
- support k8s namespace/service/deployment temporarily
SparkYuan
SparkYuan reviewed Sep 26, 2022
View reviewed changes
@SparkYuan
Copy link
Member

Pull Request Test Coverage Report for Build 3051497105

  • 91 of 160 (56.88%) changed or added relevant lines in 4 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.6%) to 73.817%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/kusionctl/cmd/apply/options.go 1 28 3.57%
pkg/engine/operation/watch.go 87 129 67.44%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 70.0%
pkg/engine/operation/parser/spec_parser.go 4 66.04%
Totals Coverage Status
Change from base Build 3043377590: -0.6%
Covered Lines: 4477
Relevant Lines: 6065

💛 - Coveralls

Please add more UTs, since the coverage decreased 0.6%

elliotxx
elliotxx previously approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@elliotxx elliotxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@howieyuen
refactor: add resource register, converter and printer workflow
10abee3 
- add Convertors to restore resource type of runtime.Object
- add TableGenerator to register new k8s resource
- add Printers to get detail and status of k8s resources
@SparkYuan
Copy link
Member

lgtm

@SparkYuan SparkYuan enabled auto-merge (squash) September 27, 2022 07:29
SparkYuan
SparkYuan approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit 27b7bda into KusionStack:main Sep 27, 2022
@howieyuen howieyuen deleted the kusion-watch branch September 27, 2022 08:49
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SparkYuan SparkYuan SparkYuan approved these changes

@elliotxx elliotxx elliotxx left review comments

+1 more reviewer

@markliby markliby markliby approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@howieyuen howieyuen

Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.
5 participants
@howieyuen @coveralls @SparkYuan @elliotxx @markliby