Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support runtime configurations in workspace #1211

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

liu-hm19
Copy link
Contributor

@liu-hm19 liu-hm19 commented Jul 9, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds supports for runtime configurations in workspace.

Which issue(s) this PR fixes:

Fixes #1192

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@coveralls
Copy link

coveralls commented Jul 10, 2024

Pull Request Test Coverage Report for Build 9872422142

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 39 of 165 (23.64%) changed or added relevant lines in 12 files are covered.
  • 33 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.3%) to 54.226%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/apply/apply.go 0 1 0.0%
pkg/engine/operation/graph/resource_node.go 1 2 50.0%
pkg/engine/runtime/terraform/terraform_runtime.go 3 6 50.0%
pkg/engine/release/util.go 0 11 0.0%
pkg/engine/runtime/terraform/tfops/workspace.go 27 55 49.09%
pkg/engine/runtime/init/init.go 0 41 0.0%
pkg/engine/runtime/kubernetes/kubernetes_runtime.go 0 41 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/engine/runtime/terraform/tfops/workspace.go 1 58.39%
pkg/engine/operation/parser/parser.go 3 79.27%
pkg/modules/generators/workload/workload_generator.go 29 81.7%
Totals Coverage Status
Change from base Build 9867753937: -0.3%
Covered Lines: 9374
Relevant Lines: 17287

💛 - Coveralls

@liu-hm19 liu-hm19 self-assigned this Jul 10, 2024
@liu-hm19 liu-hm19 added the kind/feature Categorizes issue or PR as related to a new feature label Jul 10, 2024
@liu-hm19 liu-hm19 added this to the v0.12.1 milestone Jul 10, 2024
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit 6b9c2cd into KusionStack:main Jul 10, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: support Kubernetes multi-cluster configuration
3 participants