Skip to content

bugfix: stack directory name is map key of Template.StacksConfig #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2022
Merged

bugfix: stack directory name is map key of Template.StacksConfig #105

merged 1 commit into from
Jul 25, 2022

Conversation

howieyuen
Copy link
Collaborator

wrong use stack.yaml as map key of Template.StackConfigs, stack directory name is correct.

@howieyuen howieyuen requested a review from a team July 23, 2022 12:42
@howieyuen howieyuen added kind/bug Something isn't working cli labels Jul 23, 2022
@howieyuen howieyuen added this to the v0.6.0 milestone Jul 23, 2022
@howieyuen howieyuen changed the title bugfix: stack directory name is stack name bugfix: stack directory name is map key of Template.StacksConfig Jul 23, 2022
@howieyuen howieyuen force-pushed the bugfix-stack-name branch from 626b038 to cd8b8a8 Compare July 23, 2022 12:47
@coveralls
Copy link

coveralls commented Jul 23, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.5%) to 74.509% when pulling cd8b8a8 on howieyuen:bugfix-stack-name into b9b7deb on KusionStack:main.

@howieyuen howieyuen requested a review from elliotxx July 25, 2022 03:10
@howieyuen howieyuen enabled auto-merge (squash) July 25, 2022 03:11
elliotxx
elliotxx approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@elliotxx elliotxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@howieyuen howieyuen merged commit 3299afd into KusionStack:main Jul 25, 2022
@howieyuen howieyuen deleted the bugfix-stack-name branch July 25, 2022 03:12
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elliotxx elliotxx elliotxx approved these changes

+1 more reviewer

@markliby markliby markliby approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
kind/bug Something isn't working
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@howieyuen @coveralls @elliotxx @markliby