-
Notifications
You must be signed in to change notification settings - Fork 98
Add mDns support #15
base: master
Are you sure you want to change the base?
Add mDns support #15
Conversation
kurento-media-server/entrypoint.sh
Outdated
@@ -73,3 +73,6 @@ cat /etc/hosts | sed '/::1/d' | tee /etc/hosts >/dev/null || true | |||
|
|||
# Run Kurento Media Server | |||
exec /usr/bin/kurento-media-server "$@" | |||
|
|||
# Run Avahi | |||
exec /etc/init.d/avahi-daemon start "$@" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't the first exec
replace the bach command by KMS, thus the second exec never gets executed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@j1elo, you are right, this line is not running and is not necessary, as Avahi runs as a service after installation.
mDNS is (or was) known to not work correctly inside Docker containers. Does this imply that the Troubleshooting section about mDNS & docker is outdated? Has the situation improved and now mDNS works reliably inside Docker containers? Caveat: mDNS does not work from within Docker
The way to test this is using a WebRTC-to-WebRTC connection (maybe the kurento-hello-world is enough) and see if KMS is really able to resolve the mDNS candidates that Chrome sends. |
Hi there, thanks for your Pull Request! A Kurento member needs to verify that this patch is reasonable to test. In case it is, they should write a comment with the phrase |
1 similar comment
Hi there, thanks for your Pull Request! A Kurento member needs to verify that this patch is reasonable to test. In case it is, they should write a comment with the phrase |
I saw in the official Kurento Media Server documentation that mDNS does not work properly within docker containers. However, I did several tests, all using docker, and I succeeded in all of these. There were tests using STUN / TURN and the Chrome and Firefox browsers. |
5505d51
to
541f92e
Compare
What is the current behavior you want to change?
The kurento-media-server docker does not support mDns. Before this solution, the community manually disabled the browser flag, like chrome://flags/#enable-webrtc-hide-local-ips-with-mdns
What is the new behavior provided by this change?
Add mDns support on kurento-media-server docker.
How has this been tested?
It was tested with an IP camera stream in the local network.
Types of changes
Checklist