clang-tidy fix: [modernize-use-override]

prefer using 'override' or (rarely) 'final' instead of 'virtual' [modernize-use-override]
Kurento · Apr 3, 2018 · 6346a68 · 6346a68
1 parent 7546ebd
commit 6346a68
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 15 deletions.
diff --git a/src/server/implementation/Factory.hpp b/src/server/implementation/Factory.hpp
@@ -41,8 +41,9 @@ class Factory
   virtual std::string getName() const = 0;
 
 protected:
-  virtual MediaObjectImpl *createObjectPointer (const boost::property_tree::ptree
-      &conf, const Json::Value &params) const = 0;
+  virtual MediaObjectImpl *createObjectPointer (
+      const boost::property_tree::ptree &conf,
+      const Json::Value &params) const = 0;
 };
 
 } /* kurento */

diff --git a/tests/server/sdpEndpoint.cpp b/tests/server/sdpEndpoint.cpp
@@ -41,17 +41,14 @@ struct GF {
 class SdpEndpointFactory : public Factory
 {
 public:
-  std::string getName() const
-  {
-    return "SdpEndpointFactory";
-  }
+  std::string getName () const override { return "SdpEndpointFactory"; }
 
 protected:
-  MediaObjectImpl *createObjectPointer (const boost::property_tree::ptree
-                                        &conf, const Json::Value &params) const
+  MediaObjectImpl *createObjectPointer (const boost::property_tree::ptree &conf,
+      const Json::Value &params) const override
   {
     std::string mediaPipelineId = params["mediaPipeline"].asString ();
-    bool useIpv6 = false;;
+    bool useIpv6 = false;
 
     if (params.isMember ("useIpv6") ) {
       Json::Value useIpv6Param = params["useIpv6"];

diff --git a/tests/server/uriEndpoint.cpp b/tests/server/uriEndpoint.cpp
@@ -41,14 +41,11 @@ struct GF {
 class UriEndpointFactory : public Factory
 {
 public:
-  std::string getName() const
-  {
-    return "UriEndpointFactory";
-  }
+  std::string getName () const override { return "UriEndpointFactory"; }
 
 protected:
-  MediaObjectImpl *createObjectPointer (const boost::property_tree::ptree
-                                        &conf, const Json::Value &params) const
+  MediaObjectImpl *createObjectPointer (const boost::property_tree::ptree &conf,
+      const Json::Value &params) const override
   {
     std::string mediaPipelineId = params["mediaPipeline"].asString ();
     std::string uri = params["uri"].asString ();