Skip to content

use ViewPropTypes.style instead of View.props.style #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 10, 2017
Merged

use ViewPropTypes.style instead of View.props.style #229

merged 1 commit into from
Aug 10, 2017
+3 −2

Conversation

nhducit
Copy link
Contributor

@nhducit nhducit commented Aug 9, 2017

No description provided.

@Kureev Kureev merged commit 2e279c7 into Kureev:master Aug 10, 2017
@Kureev
Copy link
Owner

Kureev commented Aug 10, 2017

Thanks, @nhducit! 🙌

@Kureev
Copy link
Owner

Kureev commented Aug 10, 2017

1.8.1 has been released with this fix

@qiangspecial
Copy link

@Kureev ViewPropTypes is support in react-native@^0.44，so if my app dependencies react-native version is lower than 0.44，it will be crash！

@nhducit
Copy link
Contributor Author

nhducit commented Aug 11, 2017

@Kureev should we revert this PR and release a new major version

@Kureev
Copy link
Owner

Kureev commented Aug 11, 2017

Right, it should've been a major bump. I'll ask npm to unpublish 1.8.1

@Kureev
Copy link
Owner

Kureev commented Aug 11, 2017 •
edited
Loading

1.8.1 has been unpublished, 2.0.0 has been released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nhducit @Kureev @qiangspecial