Moved creation of _visualEffectView out of layoutSubviews #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! Thanks for your contribution! I just released it in |
lxp-git
pushed a commit
to Flickering-AI/react-native-blur
that referenced
this pull request
Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered a problem when rotating my app. It looked like it was creating a new blur effect and placing it on top of the last one. It's also expensive to create a new UIVisualEffectView on each sublayout, which can happen during animations.
To fix this, I've moved the creation of the UIVisualEffectView up where the blur effect is created. I also set the auto resizing mask, so the bounds doesn't need to be explicitly updated.