Bugfix: change of selectedId didn't changne selected transformer box #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gne selected transformer box When change of selectedId was triggered programmatically by the application logic: only the selection of the box and display of comment box took place, Transformer box was always stuck on previously selected annotation. This did not happen when selection was changed by selecting new box with the mouse, because Transformer was set in that scenario in DefaultAnnotationState.onMouseDown. This was misleading the user. I added Next button in the storybook to reproduce the faulty behavior.
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
|
If possible, please prioritise this pull request. It's a simple fix and solves important issue for me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change of selectedId didn't changne selected transformer box
When change of selectedId was triggered programmatically by the application logic: only the
selection of the box and display of comment box took place, Transformer box was always stuck on
previously selected annotation. This did not happen when selection was changed by selecting new box
with the mouse, because Transformer was set in that scenario in DefaultAnnotationState.onMouseDown.
This was misleading the user. I added Next button in the storybook to reproduce the faulty behavior.