Repository navigation
fix(ssh): include tags and notes in launcher searches - #525
Open
Aschenbath wants to merge 1 commit into
Open
Aschenbath wants to merge 1 commit into
Aschenbath wants to merge 1 commit into
Conversation
Aschenbath
marked this pull request as ready for review
October 7, 2026 15:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Result / 用户结果
Addresses #482. The SSH host library already searches tags and notes, but the launcher, command palette and Quick Jump only searched names and addresses. All three GPUI entry points now include the existing group, tags and notes, with whitespace-separated keywords and Unicode-aware case normalization. Search retains each host's original connection identity, pin order and hidden state.
Design / 设计边界
ssh_profiles/organization.rsand one GPUI SSH row adapter for all three entry points.Evidence / 验证依据
33479963: passed.git diff --check: passed.4649c588: Windows product test binary compiled successfully; 16 targeted tests passed (6 host organization, 4 shell palette, 1 metadata projection, and 5 launcher/menu tests including real GPUI input simulation). Test configuration was isolated.Required Review / 必须确认