Skip to content

fix(ssh): include tags and notes in launcher searches - #525

Open
Aschenbath wants to merge 1 commit into
Kuddev:mainfrom
Aschenbath:fix/issue-482-ssh-search
Open

Aschenbath wants to merge 1 commit into
Kuddev:mainfrom
Aschenbath:fix/issue-482-ssh-search

Conversation

@Aschenbath

@Aschenbath Aschenbath commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Result / 用户结果

Addresses #482. The SSH host library already searches tags and notes, but the launcher, command palette and Quick Jump only searched names and addresses. All three GPUI entry points now include the existing group, tags and notes, with whitespace-separated keywords and Unicode-aware case normalization. Search retains each host's original connection identity, pin order and hidden state.

Design / 设计边界

  • Reuse the host library's metadata construction in ssh_profiles/organization.rs and one GPUI SSH row adapter for all three entry points.
  • Build metadata from the already loaded profile snapshot. No new dependency, settings format, credential access or connection behavior.
  • Update both READMEs. No new UI messages or geometry changes.

Evidence / 验证依据

  • Architecture check against 33479963: passed.
  • Architecture budget/dependency/governance tests: 54 passed.
  • Changed Rust files formatted with the pinned toolchain; git diff --check: passed.
  • Added a GPUI keyboard-input regression for tag/note/group/multi-keyword/Unicode queries, unmatched results, rendered row visibility and Escape without connecting.
  • Added row projection coverage for metadata after serialization/reload, copied-host identity, resolved address, pin/hidden order, config/recent-only hosts, and exclusion of private-key paths.
  • Commit 4649c588: Windows product test binary compiled successfully; 16 targeted tests passed (6 host organization, 4 shell palette, 1 metadata projection, and 5 launcher/menu tests including real GPUI input simulation). Test configuration was isolated.
  • Upstream Linux native CI: 2741 tests passed, 26 skipped; the log confirms both new regressions executed successfully. The independent i18n contract reports 24 passed, 1 ignored. Architecture, lint and PR size checks also passed.
  • macOS ARM64 and Intel native jobs are still queued. Windows ARM64 and manual native UI/DPI acceptance are not covered here. No pre-fix binary comparison was run. Do not merge until the remaining required CI checks pass.

Required Review / 必须确认

  • Followed contribution, architecture and project constraints.
  • Shared search fields and row presentation have one owner; no duplicate connection logic.
  • Architecture budgets unchanged and the base-relative check passes.
  • Windows targeted and Linux native regressions pass; remaining platform CI and manual acceptance limits are stated.
  • No new UI messages; bilingual documentation updated.
  • No governance changes.

@Aschenbath
Aschenbath marked this pull request as ready for review October 7, 2026 15:43
@Aschenbath
Aschenbath requested a review from Kuddev as a code owner October 7, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant