Repository navigation
fix(settings): give add-on settings pages the native content width - #503
Open
WilliamWang1721 wants to merge 4 commits into
Open
WilliamWang1721 wants to merge 4 commits into
WilliamWang1721 wants to merge 4 commits into
Conversation
SSH, backup, Agents and mobile pages each capped and centered their own column (1000/700/720/812 px) with private gutters, so they looked narrow next to the native settings pages. They now fill the shared settings column with the same gutters, and the backup storage choices use two columns on wide windows so the option rows do not stretch into long bars.
Owner
|
这项主要改变页面宽度和信息布局:除去私有留白之外,还取消了原型中明确记录的移动页宽度,并把备份选项改成两列。它不应仅按纯功能 bug 合并。 请补当前 head 的宽/窄窗口实际截图,包含 SSH、备份向导、Agent 路径状态行及手机配对状态,说明与已确认设计的对应关系。已有布局测试是有效证据,但它们更新了原居中合同,本身不构成对新设计的确认。本轮先处理功能修复,保留该 PR 等视觉核验。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Result / 用户结果
设置页中 SSH、备份、Agent、手机远程四个后加页面原先各自限宽并居中(1000 / 700 / 720 / 812 px,另带私有左右留白),与终端、外观等原生设置页相比明显偏窄。现在它们与原生页面共用同一内容列宽度和页边距;应用页(第一个 tab)保持原有 960px 上限不变。
为避免拉宽后显得松散:备份向导第一步的存储选项在宽窗(≥960px)改为两列,窄窗仍单列。
Design / 设计边界
settings_pane.rs中对 4/9/10/mobile 的items_center与 mobile 的p_0例外,删除各页自身的max_w与私有 padding。section_ssh不再需要window参数(仅用于计算私有留白)。Evidence / 验证依据
rustfmt --check(改动文件通过);构建与测试交由本 PR 的 GitHub Actions。AI 协助:Claude Opus 5.5(claude-opus-5-5),推理强度:未确认。