Repository navigation
feat(ssh): explicitly confirm changed host key updates - #459
Open
WilliamWang1721 wants to merge 12 commits into
Open
WilliamWang1721 wants to merge 12 commits into
WilliamWang1721 wants to merge 12 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Result / 用户结果
Closes #252. When a previously recorded SSH key changes, Pebrel shows the host/port and old/new SHA256 fingerprints with an identity-change warning. Connecting requires explicit confirmation and a successful targeted save; cancel and unattended probes retain the old trust record.
Design / 设计边界
Evidence / 验证依据
70539af9da7d8790c51cb7fb628e55a8cd9070dbpassed all upstream checks and all five native platforms in run 37115546218. The Windows ACL fixture removes inherited PowerShell 7 module paths before launching Windows PowerShell, preserving the strict DACL setup and equality assertion. Windows DACL preservation, locked replacement retention, real loopback SSH confirmation, dialog cancellation and unrelated malformed-key regressions passed. Maintainer/Code Owner approval remains required.AI implementation/review: GPT-6.1 SOL sub-agents; this CI fixture fix used GPT-6.1 SOL / high. Earlier coordinator model and reasoning efforts unverified.
Required Review / 必须确认