Repository navigation
feat(terminal): add independent natural-font line height setting - #445
Open
WilliamWang1721 wants to merge 6 commits into
Open
WilliamWang1721 wants to merge 6 commits into
WilliamWang1721 wants to merge 6 commits into
Conversation
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Result / 用户结果
Closes #439. Adds an editable two-decimal terminal line height (0.50–5.00) under terminal appearance. 1.00 multiplies the font's natural shaped height; explicit values override theme line height. Auto clears the override and preserves existing theme/natural spacing. The suggested 1.3–1.5 default is available explicitly; existing users keep their current layout.
Design / 设计边界
Shared settings own parsing, rounding, range and reset. The existing native font input handles Enter, blur, Tab and Escape. Startup and live prepaint use one typography function; cell layout updates the grid, PTY geometry and pointer/selection coordinates together. No dependency or theme-format change. Decision:
architecture/notes/nebula_settings/terminal_line_height/2026-10-03-natural-height-override.md.Evidence / 验证依据
Confirmed current main only exposed custom-theme line height, with no independent terminal preference. Added regression coverage for persistence/reload, reset, precision/range, real setting clicks and commit/cancel/Auto, theme precedence, device-pixel rounding, and live grid/pointer geometry.
No local tests/builds/format/architecture checks were run. Final head
6d8c6f50b5eff98941b2fa57a224d74af7a2bf5c: architecture, lint, PR size and all required reports passed. Native validation executed Linux, Windows x64 and Windows ARM64; the grid fixture consumes its real ResizeGrid notification and pointer fixtures use isolated preferences. macOS native execution was not selected by repository policy; the fork macOS native UI job passed on the same head. Real clicks/typing/Enter persisted 1.46; actual terminal text spacing measured 17→25 points. Settings and both terminal screenshots were visually reviewed at 984×667 on a 1024×768, 1× hosted display. Artifact:native-ui-pr-445-6d8c6f50b5eff98941b2fa57a224d74af7a2bf5c. Windows UI and manual high-DPI/device acceptance remain unverified. Two self-review passes completed.AI implementation/review: GPT-6.1 SOL sub-agents; coordinator model and reasoning efforts unverified.
Required Review / 必须确认