-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic BlockState Support and Misc Delegate Methods to LevelJS #464
Merged
MaxNeedsSnacks
merged 12 commits into
KubeJS-Mods:1.18/dev
from
Hunter19823:misc_additions
Aug 29, 2022
Merged
Basic BlockState Support and Misc Delegate Methods to LevelJS #464
MaxNeedsSnacks
merged 12 commits into
KubeJS-Mods:1.18/dev
from
Hunter19823:misc_additions
Aug 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y, and MoonBrightness to LevelJS
--Modifications-- BuiltinKubeJSPlugin: - Added "Properties" and "Property" binding to startup scripts for use with BlockStates BlockBuilder: - Added defaultState callback - Added placementState callback - Added BlockBuilder.property - Added BlockBuilder.boolProperty - Added BlockBuilder.enumProperty - Added BlockBuilder.dirProperty - Deprecated waterlogged BasicBlockJS - Implemented BlockBuilder.defaultState - Implemented BlockBuilder.placementState - Removed usages of BlockBuilder.waterlogged in a handful of places without removing functionality. - Added private method safeCallback for catching and logging exceptions in callback functions to startup script console. Additions: - BlockStateModifyCallbackJS (Used for registering default state) - BlockStateModifyPlacementCallbackJS (Used for modifying blockstate on placement)
… BlockBuilder to encourage reflective use instead.
- Fixed safeCallbackLogic - Made BlockBuilder.blockStateProperties immutable after creation. - Removed the last remaining uses of waterlogged - Fixed WaterLogged logic by implementing SimpleWaterloggedBlock BlockBuilder: - BlockBuilder.blockStateProperties is now a set for quick lookup times. - Added get and set methods to BlockStateModifyCallbackJS for simpler syntax and to clear rhino un-boxing issues.
ChiefArug
reviewed
Aug 25, 2022
common/src/main/java/dev/latvian/mods/kubejs/block/BlockStateModifyPlacementCallbackJS.java
Outdated
Show resolved
Hide resolved
…StateModifyPlacementCallbackJS.getItem() for use in beans
- Added BlockStateModifyPlacementCallbackJS.waterlogged() - Added BlockStateModifyPlacementCallbackJS.isWaterLogged()
- BlockStateModifyPlacementCallbackJS.isWaterLogged() is now BlockStateModifyPlacementCallbackJS.isInWater - Added BlockStateModifyPlacementCallbackJS.waterlogged(boolean)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added BlockState Support to Custom Blocks
--Modifications--
BuiltinKubeJSPlugin:
LevelJS:
BlockBuilder:
defaultState
placementState
BasicBlockJS
Additions:
Example Startup Script: