Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename tests/kuadrant to tests/singlecluster #473

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

pehala
Copy link
Contributor

@pehala pehala commented Jul 4, 2024

Since we now have multicluster tests, it makes sense to rename our current kuadrant tests to singlecluster

@jsmolar
Copy link
Contributor

jsmolar commented Jul 4, 2024

My idea is to name this single (tests/single) and multi (tests/multi) respectively.
WDYT @azgabur @averevki

@azgabur
Copy link
Contributor

azgabur commented Jul 4, 2024

Yeah I agree with Jakub, if we are already renaming, we can rename the modules to shorter names of single and multi. I dont think any meaning will get lost.

@averevki
Copy link
Contributor

averevki commented Jul 4, 2024

My idea is to name this single (tests/single) and multi (tests/multi) respectively.

I like singlecluster and multicluster better. If I see testsuite for the first time without any knowledge about it, I wouldn't know what it's mean

@jsmolar
Copy link
Contributor

jsmolar commented Jul 8, 2024

singlecluster and multicluster it is. @averevki had a good point.

@pehala pehala requested a review from averevki July 8, 2024 08:07
@averevki averevki merged commit c0b8186 into Kuadrant:main Jul 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants