Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Redis crate and use pipeline to update counters #382

Merged
merged 5 commits into from
Oct 9, 2024
Merged

Update Redis crate and use pipeline to update counters #382

merged 5 commits into from
Oct 9, 2024

Conversation

alexsnaps
Copy link
Member

No description provided.

@alexsnaps
Update Redis crate and use pipeline to update counters
2162766 
Signed-off-by: Alex Snaps <alex@wcgw.dev>
@alexsnaps
Latest stable lints
6d2e874 
Signed-off-by: Alex Snaps <alex@wcgw.dev>
@alexsnaps
Preload scripts
2f31b31 
Signed-off-by: Alex Snaps <alex@wcgw.dev>
@alexsnaps
Handle ErrorKind::NoScriptError on pipeline ourselves too
789d713 
Signed-off-by: Alex Snaps <alex@wcgw.dev>
@alexsnaps
Copy link
Member Author

Sorry, added another commit, that handles the absence of script on the server, just like Script::invoke_async does, but which won't happen when query_async on a pipeline happens... The idea is to be safe on not needing to reload the scripts when reconnecting to a fresh/new server.

@alexsnaps
Reuse the same connection to load script
9ec7b63 
Signed-off-by: Alex Snaps <alex@wcgw.dev>
eguzki
eguzki approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@eguzki eguzki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexsnaps alexsnaps merged commit 69e43a9 into main Oct 9, 2024
9 checks passed
@alexsnaps alexsnaps deleted the pipeline branch October 9, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eguzki eguzki eguzki approved these changes

@adam-cattermole adam-cattermole Awaiting requested review from adam-cattermole

Assignees
No one assigned
Labels
None yet
Projects
Kuadrant
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexsnaps @eguzki