Do not OOM due to CountersCache.Batcher getting too big
#295
Labels
kind/enhancement
New feature or request
Comments
alexsnaps
changed the title
CachedRedisStorage.CachedRedisStorage getting too bigCountersCache.Batcher getting too big
chirino
added a commit
to chirino/limitador
that referenced
this issue
Apr 30, 2024
…nded memory growth. Signed-off-by: Hiram Chirino <hiram@hiramchirino.com>
chirino
added a commit
to chirino/limitador
that referenced
this issue
Apr 30, 2024
…nded memory growth. Signed-off-by: Hiram Chirino <hiram@hiramchirino.com>
chirino
added a commit
to chirino/limitador
that referenced
this issue
Apr 30, 2024
…nded memory growth. Signed-off-by: Hiram Chirino <hiram@hiramchirino.com>
alexsnaps
pushed a commit
to alexsnaps/limitador
that referenced
this issue
Apr 30, 2024
…nded memory growth. Signed-off-by: Hiram Chirino <hiram@hiramchirino.com>
chirino
added a commit
that referenced
this issue
May 15, 2024
fixes #295: Use a semaphore to protect the Batcher from unbounded memory growth.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We need to either explicitly bound that data structure or bound it thru heuristics.
Today, it'll grow forever, most importantly when partitioned... It could certainly be compacted (e.g. expired
AtomicExpiringValue) it is mostly the key space that's the issue, as it is derived from the user's defined limits and could be really big (e.g. many conditions, large variables, ...)The text was updated successfully, but these errors were encountered: