Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: TLS and DNS Policy API cleanup #972

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: TLS and DNS Policy API cleanup #972

wants to merge 1 commit into from
+24 −141

Conversation

mikenairn
Copy link
Member

@mikenairn mikenairn commented Nov 1, 2024 •
edited
Loading

  • Remove unnecessary implementation of kuadrant.Referrer
  • Mark implementation of kuadrant.Policy as Deprecated
  • Avoid the use of Kind() method in DNS/TLS policy validator/status tasks
  • Set type of missing resource to Gateway rather than the Policy. This isn't 100% correct since it could be a section name not found, but it's closer than using the policy.

@mikenairn
chore: TLS and DNS Policy API cleanup
36283a9 
* Remove unnescaery implementation of kuadrant.Referrer
* Mark implementation of kuadrant.Policy as Deprecated
* Avoid the use of Kind() method in DNS/TLS policy validator tasks
* Set type of missing resource to Gateway rather than the Policy. This
  isn't 100% correct since it could be a section name not found, but
it's closer than using the policy.

Signed-off-by: Michael Nairn <mnairn@redhat.com>
@mikenairn mikenairn requested a review from KevFan November 1, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevFan KevFan KevFan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikenairn @KevFan