-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate AuthConfig
's v1beta3
changes in AuthPolicy
#971
base: sotw/auth
Are you sure you want to change the base?
Conversation
Signed-off-by: Adam Cattermole <acatterm@redhat.com>
Signed-off-by: Adam Cattermole <acatterm@redhat.com>
AuthConfig
v1beta3AuthConfig
's v1beta3
changes in AuthPolicy
type Predicate struct { | ||
type Condition struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somewhat confusingly we called the wasm plugin Condition
(i.e. PatternExpression
) Predicate
.. but now we have a Predicates
field in wasm and so to retain both I've renamed Predicate
-> Condition
and introduced Predicates
([]string
) in routeRuleConditions..
619602f
to
b37ca3f
Compare
Signed-off-by: Adam Cattermole <acatterm@redhat.com>
b37ca3f
to
fbec2ba
Compare
StartsWithOperator WhenConditionOperator = "startswith" | ||
EndsWithOperator WhenConditionOperator = "endswith" | ||
StartsWithOperator WhenConditionOperator = "startsWith" | ||
EndsWithOperator WhenConditionOperator = "endsWith" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not 100% about changing these - they're not used elsewhere but it's a little confusing using some within CEL predicates and others for PatternExpression
s
github.com/kuadrant/authorino v0.18.0 | ||
github.com/kuadrant/authorino v0.18.1-0.20241030162053-82d7619acc40 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now importing the version from main until we have a v0.19.0
release
Signed-off-by: Adam Cattermole <acatterm@redhat.com>
Signed-off-by: Adam Cattermole <acatterm@redhat.com>
63daafb
to
934adaf
Compare
Signed-off-by: Adam Cattermole <acatterm@redhat.com>
934adaf
to
aea75be
Compare
Verification