Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install sail-operator 0.1.0 #944

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Install sail-operator 0.1.0 #944

wants to merge 4 commits into from

Conversation

adam-cattermole
Copy link
Member

@adam-cattermole adam-cattermole commented Oct 17, 2024

Installs sail-operator using helm from istio-ecosystem/sail-operator@0.1.0 and re-enables integration tests.

Requires #893
Continues #696
Closes #401

@adam-cattermole
Copy link
Member Author

I have tested on top of RLP from #893 and can see things working as expected.

Comment on lines +6 to +7
# Supported values for sail-operator v0.1.0 are [v1.22.4,v1.23.0]
version: v1.23.0
Copy link
Member Author

@adam-cattermole adam-cattermole Oct 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that whilst the supported versions listed here are the ones permitted by the CRD, the operator fails to configure the supported profile when set to v1.22.4 so in reality there's only the option of v1.23.0

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What version of GWAPI does that align with?

Copy link
Member Author

@adam-cattermole adam-cattermole Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe v1.23 is still GWAPI v1.1 and istio v1.24 will support GWAPI v1.2

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.00%. Comparing base (63f1d28) to head (0892348).
Report is 37 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #944      +/-   ##
==========================================
- Coverage   81.49%   79.00%   -2.49%     
==========================================
  Files         102      115      +13     
  Lines        7177     9661    +2484     
==========================================
+ Hits         5849     7633    +1784     
- Misses        898     1624     +726     
+ Partials      430      404      -26     
Flag Coverage Δ
bare-k8s-integration 9.37% <ø> (+0.47%) ⬆️
controllers-integration 67.94% <ø> (+2.62%) ⬆️
envoygateway-integration 47.33% <ø> (-2.97%) ⬇️
gatewayapi-integration 13.15% <ø> (-1.26%) ⬇️
istio-integration 49.43% <ø> (-4.09%) ⬇️
unit 27.42% <ø> (-0.93%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) 90.00% <ø> (-0.91%) ⬇️
api/v1beta2 (u) ∅ <ø> (∅)
pkg/common (u) 87.67% <88.88%> (-0.47%) ⬇️
pkg/istio (u) 58.57% <72.05%> (-12.95%) ⬇️
pkg/log (u) 93.18% <ø> (-1.56%) ⬇️
pkg/reconcilers (u) ∅ <ø> (∅)
pkg/rlptools (u) ∅ <ø> (∅)
controllers (i) 82.68% <84.23%> (-0.38%) ⬇️

see 73 files with indirect coverage changes

Add back fail-fast removal

Signed-off-by: Adam Cattermole <acatterm@redhat.com>
Signed-off-by: Adam Cattermole <acatterm@redhat.com>
@adam-cattermole adam-cattermole marked this pull request as ready for review October 30, 2024 09:44
Additionally, istio default intallation tool in dev environments now it is Sail Operator

Signed-off-by: Eguzki Astiz Lezaun <eastizle@redhat.com>
@maleck13
Copy link
Collaborator

changes look good. I will verify it here locally also before approving

@adam-cattermole
Copy link
Member Author

I've tested this locally on top of the changes from #952 and the auth side of things is working

@maleck13
Copy link
Collaborator

@adam-cattermole is there anything that needs to be done with the quick start? Still haven't got to try this out yet have a backlog of stuff at the moment. Happy to approve though as you seem to have done a fair bit of validation here

@adam-cattermole
Copy link
Member Author

No worries, I'll have a go with the quickstart and report back, but either way I think I'll wait on merge until #952 is in

Signed-off-by: Adam Cattermole <acatterm@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Changes dependencies kind/enhancement New feature or request size/medium
Projects
Status: Ready For Review
Development

Successfully merging this pull request may close these issues.

Installing sail operator without kustomize
3 participants