-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install sail-operator 0.1.0 #944
base: main
Are you sure you want to change the base?
Conversation
I have tested on top of RLP from #893 and can see things working as expected. |
# Supported values for sail-operator v0.1.0 are [v1.22.4,v1.23.0] | ||
version: v1.23.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that whilst the supported versions listed here are the ones permitted by the CRD, the operator fails to configure the supported profile when set to v1.22.4 so in reality there's only the option of v1.23.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What version of GWAPI does that align with?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe v1.23 is still GWAPI v1.1 and istio v1.24 will support GWAPI v1.2
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #944 +/- ##
==========================================
- Coverage 81.49% 79.00% -2.49%
==========================================
Files 102 115 +13
Lines 7177 9661 +2484
==========================================
+ Hits 5849 7633 +1784
- Misses 898 1624 +726
+ Partials 430 404 -26
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Add back fail-fast removal Signed-off-by: Adam Cattermole <acatterm@redhat.com>
Signed-off-by: Adam Cattermole <acatterm@redhat.com>
569f088
to
e5282c0
Compare
Additionally, istio default intallation tool in dev environments now it is Sail Operator Signed-off-by: Eguzki Astiz Lezaun <eastizle@redhat.com>
changes look good. I will verify it here locally also before approving |
I've tested this locally on top of the changes from #952 and the auth side of things is working |
@adam-cattermole is there anything that needs to be done with the quick start? Still haven't got to try this out yet have a backlog of stuff at the moment. Happy to approve though as you seem to have done a fair bit of validation here |
No worries, I'll have a go with the quickstart and report back, but either way I think I'll wait on merge until #952 is in |
Signed-off-by: Adam Cattermole <acatterm@redhat.com>
Installs sail-operator using helm from istio-ecosystem/sail-operator@0.1.0 and re-enables integration tests.
Requires #893
Continues #696
Closes #401