Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin dns operator version v0.1.0 #457

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

mikenairn
Copy link
Member

@mikenairn mikenairn commented Mar 12, 2024

We intend to make non backward compatible changes in the DNS Operator and having the main branch here track the development branch of DNS Operator will result in broken builds/tests until we update this repo.

Generally its probably a better option (IMO) to pin versions of these sub components anyway otherwise how do you know what you are actually testing, and why would you want to be forced to release a sub component (Authorino, Limitador, DNS ....) that might not be ready when deciding to release a new minor version of kuadrant operator?

@mikenairn mikenairn requested a review from a team as a code owner March 12, 2024 12:24
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Merging #457 (38d0a0b) into main (93d2265) will decrease coverage by 51.89%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #457       +/-   ##
===========================================
- Coverage   81.91%   30.03%   -51.89%     
===========================================
  Files          54       58        +4     
  Lines        4452     4132      -320     
===========================================
- Hits         3647     1241     -2406     
- Misses        534     2822     +2288     
+ Partials      271       69      -202     
Flag Coverage Δ
integration ?
unit 30.03% <ø> (+1.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) ∅ <ø> (∅)
api/v1beta2 (u) 50.71% <ø> (-40.20%) ⬇️
pkg/common (u) 87.70% <ø> (-2.17%) ⬇️
pkg/istio (u) 41.61% <ø> (-33.55%) ⬇️
pkg/log (u) 36.84% <ø> (-57.90%) ⬇️
pkg/reconcilers (u) 38.20% <ø> (-43.62%) ⬇️
pkg/rlptools (u) 56.40% <ø> (-23.06%) ⬇️
controllers (i) 8.09% <ø> (-71.33%) ⬇️

see 67 files with indirect coverage changes

Copy link
Contributor

@KevFan KevFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@didierofrivia
Copy link
Collaborator

I'd say that nobody should trust any floating tags and people should go for released versions... However, having a failing main branch is not ideal. I have mixed feeling about this, maybe we should define what is expected from the main branch and if we could start pinning versions to it. Would love to hear what others have to say about this, maybe if we decide to go for versioning and v.x.y.z-dev tags for main would make more sense, https://github.com/Kuadrant/architecture/pull/41/files?short_path=eeceecb#diff-eeceecbdf5c1a6fc2cc490b55dd4351651d64c8a740458325511493e52f7616a

@maleck13 maleck13 merged commit ece13e8 into Kuadrant:main Mar 13, 2024
15 of 16 checks passed
@mikenairn mikenairn deleted the pin_dns_operator_version_v0.1.0 branch March 13, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants