Skip to content

Commit

Permalink
fix lint issues
Browse files Browse the repository at this point in the history
  • Loading branch information
eguzki committed Apr 9, 2024
1 parent 9f58378 commit 979ae5e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
6 changes: 1 addition & 5 deletions controllers/ratelimitpolicy_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -165,11 +165,7 @@ func (r *RateLimitPolicyReconciler) reconcileResources(ctx context.Context, rlp
}

// set direct back ref - i.e. claim the target network object as taken asap
if err := r.reconcileNetworkResourceDirectBackReference(ctx, rlp, targetNetworkObject); err != nil {
return err
}

return nil
return r.reconcileNetworkResourceDirectBackReference(ctx, rlp, targetNetworkObject)

Check warning on line 168 in controllers/ratelimitpolicy_controller.go

View check run for this annotation

Codecov / codecov/patch

controllers/ratelimitpolicy_controller.go#L168

Added line #L168 was not covered by tests
}

func (r *RateLimitPolicyReconciler) deleteResources(ctx context.Context, rlp *kuadrantv1beta2.RateLimitPolicy, targetNetworkObject client.Object) error {
Expand Down
2 changes: 1 addition & 1 deletion pkg/library/mappers/gateway_to_limitador.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ func NewGatewayToLimitadorEventMapper(o ...MapperOption) *GatewayToLimitadorEven
// approach:
// Gateway -> get Kuadrant NS
// Kuadrant NS -> Limitador CR NS/name
func (k *GatewayToLimitadorEventMapper) Map(ctx context.Context, obj client.Object) []reconcile.Request {
func (k *GatewayToLimitadorEventMapper) Map(_ context.Context, obj client.Object) []reconcile.Request {
logger := k.opts.Logger.WithValues("object", client.ObjectKeyFromObject(obj))

Check warning on line 30 in pkg/library/mappers/gateway_to_limitador.go

View check run for this annotation

Codecov / codecov/patch

pkg/library/mappers/gateway_to_limitador.go#L29-L30

Added lines #L29 - L30 were not covered by tests

gateway, ok := obj.(*gatewayapiv1.Gateway)
Expand Down

0 comments on commit 979ae5e

Please sign in to comment.