-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI #366
CLI #366
Conversation
) | ||
|
||
type envVar interface { | ||
string | int | int64 | bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! so we can use union types :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. Called "constraints" in golang.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the fact that we can restrict how "generic" our interfaces are
6677f08
to
cf57d88
Compare
…iable declarations
cf57d88
to
bff3d02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
Defines command-line interface (CLI) for:
Options of authorisation server should now be supplied using flags of the
authorino server
command.This deprecates the usage of environment variables to set the options of the authorisation server, though they are still available to override defaults used in case the corresponding flag is not supplied in the command, and for backward compatibility until the Authorino Operator is updated to use the flags.
Closes #363.
Verification steps
Build:
Help command:
Version:
Setup a local cluster (to test running the server locally):
Run the server:
(with default settings...)
(changing a setting...)
(overriding a default...)
(with the specified flag taking precendence over any default...)