Red Hat Universal Base Image (UBI) 8 #332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guicassolato
force-pushed
the
ubi8
branch
3 times, most recently
from
9494aa5 to
defd03e
Compare
- Builder: go-toolset - Runtime: ubi-minimal
guicassolato
commented
Jul 26, 2022
| FROM golang:1.17 as builder | ||
|
|
||
| FROM registry.access.redhat.com/ubi8/go-toolset:1.17.10 as builder | ||
| USER root |
There was a problem hiding this comment.
When you build an image on a Red Hat UBI that includes a language runtime, the user is already switched to a non-root user named
default.
gsaslis
approved these changes
Jul 27, 2022
gsaslis
reviewed
Jul 27, 2022
| @@ -1,17 +1,15 @@ | |||
| # Build the authorino binary | |||
| FROM golang:1.17 as builder | |||
|
|
|||
| FROM registry.access.redhat.com/ubi8/go-toolset:1.17.10 as builder | |||
There was a problem hiding this comment.
might want to use 1.17 floating tag?
There was a problem hiding this comment.
Same conversation going on here: Kuadrant/authorino-operator#85 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes container base image to Red Hat UBI 8 images.
As a side effect, image size will grow from ~25-27 MB to ~59-63 MB (depending on the platform – linux/arm64 or linux/amd64, respectively).
On the good side, automated security scans in Quay.io will work (closes #310).