Add casting operators for int? and long?

[carlosjdelgado]

With this change I try to fix the following case:

 return new KrpcQuery
 {
         Id = queryDictionary.Get<BString>("id")?.ToString(),
         InfoHash = queryDictionary.Get<BString>("info_hash")?.ToString(),
         Target = queryDictionary.Get<BString>("target")?.ToString(),
         ImpliedPort = queryDictionary.Get<BNumber>("implied_port"), // ImpliedPort is an int?
         Token = queryDictionary.Get<BString>("token")?.ToString()
 };

This throws InvalidCastException, when try to get "implied_port" key, I want to get null if does not exist in the dictionary.

[coveralls]

Coverage increased (+0.3%) to 77.633% when pulling 81f38a5 on carlosjdelgado:add-nullable-bnumber-castings into fe550e9 on Krusen:master.

[Krusen]

Thanks for the PR.

Your tests doesn't actually test your added code but instead tests casting from int?/long? to BNumber.

If you can change the tests to the following I can get this merged :)

[Fact]
public void CanCastToNullableInt_WhenNull()
{
    BNumber bnumber = null;
    var number = (int?) bnumber;
    number.Should().BeNull();
}

[Fact]
public void CanCastToNullableLong_WhenNull()
{
    BNumber bnumber = null;
    var number = (long?) bnumber;
    number.Should().BeNull();
}

[Fact]
public void CanCastToNullableInt_WhenNotNull()
{
    var bnumber = new BNumber(42);
    var number = (int?) bnumber;
    number.Should().Be(42);
}

[Fact]
public void CanCastToNullableLong_WhenNotNull()
{
    var bnumber = new BNumber(42);
    var number = (long?) bnumber;
    number.Should().Be(42);
}

[carlosjdelgado]

What a mistake 😌, I'll fix it as soon as possible, thanks!

[carlosjdelgado]

@Krusen I had fixed tests covering all cases (casting from and to int, long, nullable int and nullable long)

Will it be possible to have a new nuget version with these changes?

[Krusen]

Thanks!

Version 2.3.0 has been published.