Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Elixir prefix in debugger blacklist. #817

Merged
merged 6 commits into from
Sep 5, 2017

Conversation

merqlove
Copy link
Contributor

@merqlove merqlove commented Sep 1, 2017

Auto add this prefix if string is not lowercase.

Changelog

Enhancements

  • Add note to README that atom module names should be prefixed with :

Bug Fixes

  • Support atoms (prefixed with :) andElixir. and plain Aliases for debugger blacklist.

@KronicDeth
Copy link
Owner

We can use this for now, but I bet for some weird reason, capitalized Erlang module names other than Elixir modules exist. If we find one, we'll need to change the blacklist to expect :atom for true Erlang module names that are lower case OR require : before capitalized names that should NOT have Elixir. added.

@merqlove
Copy link
Contributor Author

merqlove commented Sep 4, 2017

I like idea to check for : if module name so unique.

@merqlove
Copy link
Contributor Author

merqlove commented Sep 4, 2017

Fixed with one-liner.

@KronicDeth KronicDeth merged commit c18bbbd into KronicDeth:master Sep 5, 2017
KronicDeth added a commit that referenced this pull request Sep 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants