Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move {3} inside | for SIGIL PROMOTER and TERMINATOR #750

Merged
merged 2 commits into from
Jul 27, 2017
Merged

Move {3} inside | for SIGIL PROMOTER and TERMINATOR #750

merged 2 commits into from
Jul 27, 2017

Conversation

KronicDeth
Copy link
Owner

Fixes #674

Changelog

Enhancements

Bug Fixes

Fixes #674

> ```
> SIGIL_HEREDOC_PROMOTER = ({SIGIL_DOUBLE_QUOTES_PROMOTER}|>
> {SIGIL_SINGLE_QUOTES_PROMOTER}){3}
> SIGIL_HEREDOC_TERMINATOR = ({SIGIL_DOUBLE_QUOTES_TERMINATOR}|>
> {SIGIL_SINGLE_QUOTES_TERMINATOR}){3}
> ```
> --
> https://github.com/KronicDeth/intellij-elixir/blob/v5.1.0/src/org/elixir_lang/Elixir.flex?utf8=%E2%9C%93#L524-L525

The `|` is inside group that is then `{3}`'d, so it allows either `'` or
`"` in groups of three.  This is only applies to the sigils.  It's
correct for normal string and charlist heredocs:

> ```
> CHAR_LIST_HEREDOC_PROMOTER = {CHAR_LIST_PROMOTER}{3}
> CHAR_LIST_HEREDOC_TERMINATOR = {CHAR_LIST_TERMINATOR}{3}
>
> STRING_HEREDOC_PROMOTER = {STRING_PROMOTER}{3}
> STRING_HEREDOC_TERMINATOR = {STRING_TERMINATOR}{3}
>
> QUOTE_HEREDOC_PROMOTER = {CHAR_LIST_HEREDOC_PROMOTER} |
> {STRING_HEREDOC_PROMOTER}
> QUOTE_HEREDOC_TERMINATOR = {CHAR_LIST_HEREDOC_TERMINATOR} |
> {STRING_HEREDOC_TERMINATOR}
> ```
> --
> https://github.com/KronicDeth/intellij-elixir/blob/v5.1.0/src/org/elixir_lang/Elixir.flex?utf8=%E2%9C%93#L441-L448
@KronicDeth KronicDeth added this to the v6.0.0 milestone Jul 27, 2017
@KronicDeth KronicDeth self-assigned this Jul 27, 2017
@KronicDeth KronicDeth merged commit 94c08c7 into master Jul 27, 2017
@KronicDeth KronicDeth deleted the 674 branch July 27, 2017 01:50
KronicDeth added a commit that referenced this pull request Jul 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant