Bug fixes #634
Merged
Bug fixes #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Occurs when qualified call occurs over a line with assignment ot a
tuple, such as `Qualifier.\n{:ok, value} = call()`.
Completion of bare words as call definition clauses (functions or macros) had a detrimental impact on typing feedback, which became excessive once the index of call definition clauses was expanded by the decompilation of the Elixir standard library `.beam`s, so disable it. If bare-words completion is restored. It will either (1) need to not use the `Reference#getVariants()` API because it generates too many objects that need to be thrown away or (2) need to only complete call definition clauses that are provably in-scope from imports or other macros.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Bug Fixes
Variablescope forQualifiedMultipleAliases, which occurs when qualified call occurs over a line with assignment to a tuple, such asESCwas hit to cancel the completion, which became excessive once the index of call definition clauses was expanded by the decompilation of the Elixir standard library.beams, so disable it. If bare-words completion is restored. It will either (1) need to not use theReference#getVariants()API because it generates too many objects that need to be thrown away or (2) need to only complete call definition clauses that are provably in-scope from imports or other macros.