Multiresolve to alias and defmodule #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nested modules jumping to the alias loses the context of the nested name, so in addition to resolving to the alias, also resolve to the final, unaliased defmodule.
Multiresolve works for the aliased name itself, not just nested modules under the aliased name.
Missing `getName` declaration in Elixir.bnf had UnmatchedQualifiedAlias using the PsiNamedElement.getName, which returned null and broke display of element for the Choose Declaration lookup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #404
Changelog
Enhancements
as:aliased name to bothaliasanddefmoduleas:aliased name.Bug Fixes
aliasanddefmodule, as resolving to only thealiasloses the nested name, so it wasn't possible to jump to the nested name's `defmodule.aliasand thedefmodule, so you can skip jumping to thealiasbefore jumping to thedefmodule.