Build jps-builder using only Java 1.6 compatible .classes #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #290 Fixes #293 Fixes #295 Fixes #302 Fixes #313 In IntelliJ 14.1, all of openapi.jar targets Java 1.6 (with MAJOR.MINOR 50.0), but in IntelliJ 2016.1, some of openapi.jar targets only Java 1.8 (with MAJOR.MINOR 52.0), since jps-builders require parts of openapi.jars and must target Java 1.6 even for IntelliJ 2016.1, the 52.0 .classes needed to be ported into org.elixir_lang.jps.builder, so that the 52.0 version in openapi.jar wouldn't be attempted to be loaded. This ended up being 5 classes: * ExecutionException * GeneralCommandLine * ParametersList * ParamsGroup * ProcessNotCreatedException Only GeneralCommandLine was used directly, all others are dependencies of it.
KronicDeth
added a commit
that referenced
this pull request
Jun 12, 2016
KronicDeth
added a commit
that referenced
this pull request
Jun 14, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #290
Fixes #293
Fixes #295
Fixes #302
Fixes #313
Changelog
Bug Fixes
In IntelliJ 14.1, all of
openapi.jartargets Java 1.6 (withMAJOR.MINOR50.0), but in IntelliJ 2016.1, some ofopenapi.jartargets only Java 1.8 (withMAJOR.MINOR52.0), sincejps-buildersrequire parts ofopenapi.jarand must target Java 1.6 even for IntelliJ 2016.1, the52.0.classes needed to be ported intoorg.elixir_lang.jps.builder, so that the52.0version inopenapi.jarwouldn't be attempted to be loaded.This ended up being 5 classes:
ExecutionExceptionGeneralCommandLineParametersListParamsGroupProcessNotCreatedExceptionOnly
GeneralCommandLinewas used directly, all others are dependencies of it.Thanks
Thanks to @cedriessen for pointing that all the weird loading bugs were related to ignatov/intellij-erlang#727 and then @ignatov, @deadok22, and @chashnikov for helping from that issue.