Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work-around Find Usage bug only in versions that have Find Usages bug #2461

Merged
merged 9 commits into from
Jan 13, 2022

Conversation

KronicDeth
Copy link
Owner

@KronicDeth KronicDeth commented Jan 9, 2022

Fixes #2374

(For reals this time 😉 )

Changelog

Enhancements

  • Test against support IDEA versions in CI to prevent another Find Usage regression
    • 2021.2.3 FindUsageTests differ from manual testings, so don't test 2021.2.3
    • Make FindUsagesTest UsageViewTreeText work for both 2021.1.3 and other versions
    • Add kernel.ex to all Find Usage Tests to ensure it doesn't work because it can't resolve primary element
  • Add find usages for def test

Bug Fixes

  • Work-around Find Usage bug due to temporary change in JetBrains API only in versions that have that change.
    • Restore old find_usages.handler.Call
    • Determine whether to resolve FindUsageHandler primary element based on application build number
      Assume that are 213.* builds have the already resolved call. This excludes 2021.3, but not 2021.3.1, which includes the fix to restore the 2021.1.3 behaviour.

@KronicDeth KronicDeth force-pushed the 2374 branch 4 times, most recently from 5465eb8 to 7cf3e37 Compare January 9, 2022 04:39
@KronicDeth KronicDeth force-pushed the 2374 branch 2 times, most recently from 948f135 to a3266b1 Compare January 10, 2022 19:05
@KronicDeth KronicDeth self-assigned this Jan 13, 2022
@KronicDeth KronicDeth changed the title Expand to a test matrix to protect from #2374 regression Work-around Find Usage bug only in versions that have Find Usages bug Jan 13, 2022
@KronicDeth KronicDeth added this to the 12.2.0 milestone Jan 13, 2022
@KronicDeth KronicDeth marked this pull request as ready for review January 13, 2022 03:12
@KronicDeth KronicDeth merged commit 36099c8 into main Jan 13, 2022
@KronicDeth KronicDeth deleted the 2374 branch January 13, 2022 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Find Usages(⌥ F7) not working.
1 participant