fix: Alternative function clause for put_event with suite_finished #2074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using Elixir 1.12 and ExUnit, a test run ends in this warning:
```
warning: TeamCityExUnitFormatting does not know how to process event ({:suite_finished, %{async: 64164, load: nil, run: 121385}}). Please report this message to https://github.com/KronicDeth/intellij-elixir/issues/new.
/tmp/intellij_elixir/exunit/1.6.0/team_city_ex_unit_formatting.ex:210: TeamCityExUnitFormatting.put_event/2
/tmp/intellij_elixir/exunit/1.6.0/team_city_ex_unit_formatter.ex:11: TeamCityExUnitFormatter.handle_cast/2
(stdlib 3.15.2) gen_server.erl:695: :gen_server.try_dispatch/4
(stdlib 3.15.2) gen_server.erl:771: :gen_server.handle_msg/6
(stdlib 3.15.2) proc_lib.erl:226: :proc_lib.init_p_do_apply/3
```
Looks to me like the function call might have changed, so I've added another clause to take that into account, while keeping the previous one for compatibility with previous versions.
Thau
changed the title
This was referenced Oct 21, 2021
KronicDeth
added a commit
that referenced
this pull request
Nov 5, 2021
KronicDeth
added a commit
that referenced
this pull request
Nov 5, 2021
KronicDeth
added a commit
that referenced
this pull request
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Elixir 1.12 and ExUnit, a test run ends in this warning:
Looks to me like the function call might have changed, so I've added another clause to take that into account, while keeping the previous one for compatibility with previous versions.
Solves #2045, #2016, and #1949