Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BEAM Chunks tab labels not displaying #1999

Merged
merged 3 commits into from
Jul 1, 2021
Merged

Fix BEAM Chunks tab labels not displaying #1999

merged 3 commits into from
Jul 1, 2021

Conversation

KronicDeth
Copy link
Owner

Fixes #1918

Changelog

Bug Fixes

  • Implement beam.FileEditor#getFile to fix DeprecatedMethodException as the default implementation is now deprecated and requires an explicit implementation.
  • Use TabbedPaneWrapper.AsJBTabs instead of JBTabbedPane for "BEAM Chunks" tabs.
    I'm not sure why JBTabbedPane stopped showing its labels sometime in the 2020.X IDE version series, but by debugging when "BEAM Chunks" name was retrieved I found that the bottom tabs used TabbedPaneWrapper.asJBTabs. Using that, the labels reappeared.

Fixes DeprecatedMethodException on #getFile.
…s tabs

Fixes #1918

I'm not sure why JBTabbedPane stopped showing its labels sometime in the 2020.X IDE version series, but by debugging when "BEAM Chunks" name was retrieved I found that the bottom tabs used TabbedPaneWrapper.asJBTabs.  Using that, the labels reappeared.
@KronicDeth KronicDeth added this to the 11.11.1 milestone Jul 1, 2021
@KronicDeth KronicDeth self-assigned this Jul 1, 2021
KronicDeth added a commit that referenced this pull request Jul 1, 2021
@KronicDeth KronicDeth merged commit bd47827 into main Jul 1, 2021
@KronicDeth KronicDeth deleted the chunk-tabs branch July 1, 2021 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Beam Chunks Tab Labels Not Rendering
1 participant