Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore incompleteCode flag #1630

Merged
merged 8 commits into from
Dec 1, 2019
Merged

Ignore incompleteCode flag #1630

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
811f927
Extend invalid ResolveResult to qualified calls too
KronicDeth Nov 29, 2019
bd1afb4
Extend the loosening of ResolveResults to @psec
KronicDeth Nov 29, 2019
6440e49
Loosen CallDefinitionClause MultiResolve invalid ResolveResult
KronicDeth Nov 29, 2019
508ee2f
Invalid ResolveResult without incomplete code for alias
KronicDeth Nov 29, 2019
256f1bb
Allow invalid module attribute ResolveResult even when not incomplete…
KronicDeth Nov 29, 2019
9c0ab28
Variable invalid result as long as prefix match
KronicDeth Nov 29, 2019
d2d0851
Allow invalidResult for @protocol and @for prefix
KronicDeth Nov 29, 2019
6728c00
Add #1630 to changelogs
KronicDeth Dec 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Loosen CallDefinitionClause MultiResolve invalid ResolveResult 
Apply same name prefix precondition and then set to valid iff resolved
final arity within range and the name is an exact match.
  • Loading branch information
@KronicDeth
KronicDeth committed Nov 29, 2019
commit 6440e49f22c394fb15ebf559456e8de05295589f
6 changes: 2 additions & 4 deletions src/org/elixir_lang/psi/scope/call_definition_clause/MultiResolve.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,11 @@ private constructor(private val name: String,
nameArityRange(element)?.let { nameArityRange ->
val name = nameArityRange.name

if (name == this.name) {
if (name.startsWith(this.name)) {
val arityInterval = ArityInterval.arityInterval(nameArityRange, state)
val validResult = resolvedFinalArity in arityInterval
val validResult = (resolvedFinalArity in arityInterval) && name == this.name

addToResolveResults(element, validResult, state)
} else if (incompleteCode && name.startsWith(this.name)) {
addToResolveResults(element, false, state)
} else {
null
}
Expand Down