2019.2 compatibility #1545
Merged
2019.2 compatibility #1545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid reflection from now on to spot incompatibilities at compile time.
2019.2 extracted the Java functionality to a plugin (as outlined here https://blog.jetbrains.com/platform/2019/06/java-functionality-extracted-as-a-plugin/), which includes the JPS builder.
Project converters are broken in 2019.2 because the DialogWrapper they try to launch isn't being launched in the Event Dispacht Thread (EDT) (https://youtrack.jetbrains.com/issue/IDEA-218071). As this is bug in code wholey controlled by upstream, the only option is to remove the project converters. The work-around is for users to re-import projects when a project layout update is necessary.
It was needed for backwards compatibility, but since this build is for 2019.2 only, no compatibility is necessary and it clears up the long warnings from the logs for end users.
Fixes #1527 JetBrains has removed dependency injection for Extensions in 2019.2.
Only 2019.2 is now supported, so no need for complicated backwards compatibility.
It will be 1 year since the last 1.6 update on the 19th, so close enough to retire.
Can't run because of bug in OpenAPI: ``` com.intellij.openapi.options.SchemeManagerFactory requested as a service, but it is a component - convert it to a service or change call to ApplicationManager.getApplication().getComponent() ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1527
Changelog
Enhancements
Bug Fixes
Explicitly depend on java plugin. 2019.2 extracted the Java functionality to a plugin (as outlined here), which includes the JPS builder used for Project Build functionality.
Remove project converterts. Project converters are broken in 2019.2 because the
DialogWrapperthey try to launch isn't being launched in the Event Dispatch Thread (EDT) (https://youtrack.jetbrains.com/issue/IDEA-218071).As this is bug in code wholey controlled by upstream, the only option is to remove the project converters. The work-around is for users to re-import projects when a project layout update is necessary.
Fix nullability of
overridearguments inChooseByNameModelDon't use dependency injection for OpenProcessor builder. JetBrains has removed dependency injection for Extensions in 2019.2.
Don't pass a null name ot findSdk
Incompatible Changes