Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache all computed Elixir levels #1408

Merged
merged 4 commits into from
Mar 7, 2019
Merged

Cache all computed Elixir levels #1408

merged 4 commits into from
Mar 7, 2019

Conversation

KronicDeth
Copy link
Owner

@KronicDeth KronicDeth commented Mar 7, 2019

Changelog

Bug Fixes

  • Cache all computed Elixir levels at the file, module, project, and SDK levels. The computed Elixir level is used to determine how to emulate the various grammar changes made for the different Elixir versions. This bug was potentially introduced as earlier asv7.0.0 (2017-12-15) and as late as v7.5.0 (2018-06-03) as that's the history for LevelPropertyPusher.java and has affected all later versions. If you ever experienced the 6.X series as faster than the 7.X series and later, this bug may be why and you should upgrade/reinstall immediately.

Fixes #1400

1. LevelPropertyPusher was writing LEVEL key for project, but nowhere else.
2. Most usages were bypassing the LEVEL key cache and calling the
compute methods directly.
@KronicDeth KronicDeth self-assigned this Mar 7, 2019
@KronicDeth KronicDeth merged commit 9d8eac9 into master Mar 7, 2019
@KronicDeth KronicDeth deleted the 1400 branch March 7, 2019 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant