Lex atoms with one rules instead of pieces #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Atom lexing was parsing the ATOM_START or OPERATOR first and only if ATOM_START was the longer match, did it try to match the ATOM_MIDDLE and ATOM_END. I removed this extra state and have ATOM match all three ATOM_* parts using the same pattern as used in IDENTIFIER, which means that operators that prefix longer atoms no longer stop the lexing of the atom fragment.
KronicDeth
added a commit
that referenced
this pull request
Jun 22, 2015
KronicDeth
added a commit
that referenced
this pull request
Jun 22, 2015
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #133
Atom lexing was parsing the ATOM_START or OPERATOR first and only if ATOM_START was the longer match, did it try to match the ATOM_MIDDLE and ATOM_END. I removed this extra state and have ATOM match all three ATOM_* parts using the same pattern as used in IDENTIFIER, which means that operators that prefix longer atoms no longer stop the lexing of the atom fragment.