Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update admin.py #268

Closed
wants to merge 2 commits into from
Closed

Update admin.py #268

wants to merge 2 commits into from

Conversation

icatalina
Copy link
Contributor

Removing patterns('', as it's deprecated in django 1.9 and was causing errors in the unittest

django.utils.deprecation.RemovedInDjango110Warning: django.conf.urls.patterns() is deprecated and will be removed in Django 1.10. Update your urlpatterns to be a list of django.conf.urls.url() instances instead.

@icatalina
Update admin.py
e26be62 
Removing patterns('', as it's deprecated in django 1.9 and was causing errors in the unittest
@spectras
Copy link
Collaborator

spectras commented Dec 9, 2015

Good catch, thanks, I'll review and merge within the week.

@icatalina
Making use of the argument 'from_field' when overwriting get_object
70ec0c3 
In Django 1.8, there's a new argument for get_object ('from_field') if
not used, django will try to use the pk on a foreign key.

https://docs.djangoproject.com/en/1.9/releases/1.8/#id2
@icatalina
Copy link
Contributor Author

I'm not expert in Django/Python, it seems like this is the right solution, but I'm not sure.

@spectras spectras closed this in 01ee36a Dec 13, 2015
@spectras spectras added this to the v1.5.0 milestone Dec 13, 2015
@spectras spectras self-assigned this Dec 13, 2015
@spectras
Copy link
Collaborator

Thanks!
I merged the first commit (the removal of patterns), which will be included in next release. Also was an opportunity to see there as still quite some other deprecation warnings, I ought to give them some time at some point.
I did not look into the other commit, because it looks it is a completely unrelated thing. Could you open another PR for this?

@icatalina
Copy link
Contributor Author

Sorry, I wanted to do a different pull request, I'm too new to github and it seems I made them together... hehe

Also, I've noticed that some test were failing on the second pull request, I'll fix them and try to make a new pull request for everything together (test and changes).

Thanks for merging the first one :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@spectras spectras

Labels
improvement
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@icatalina @spectras