✨ added CSRF attack detection #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh neat, this also has the added benefit, that refreshing the "/api/discord/callback" page, right after authorization, won't send any additional requests to Discord and just fail. Should I add a note to the comments or possibly even adjust the error handling, so it silently rejects the request instead of claiming it was a CSRF attack? |
|
Yeah silently rejecting the request should be fine. |
|
Alright, I think this is reasonably silent now. I'll adjust the clean branches for you too, I just need to set up my dev environment first. |
|
It's fine, I can adjust the clean branch. |
|
By the way, for the future, we can just copy paste the index.js from master to clean and github will clean it automatically after pushing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.