winetricks_init: Do not create a new wineprefix#25
Draft
Conversation
As refferenced on Winetricks#1344 making a new wineprefix is creating conflicts for installers that are using custom WINE, this resolves it and seems to fix Winetricks#599 as well. Adding `winetricks_set_wineprefix` to some verbs might be required, so far no conflicts on WINE 4.17 packaged by Debian. Fixes: Winetricks#1344 Fixes: Winetricks#1335 Fixes: Winetricks#1347 Allows adaptation using: Winetricks#1348 Signed-off-by: Jacob Hrbek <kreyren@rixotstudio.cz>
Kreyren
added
P5 - Unimportant
Member
Author
|
Priority lowered since winetricks maintainers are messing with wineprefix functions atm (Winetricks#1418) and i'm on vacation where i can't test this. |
Kreyren
force-pushed
the
master
branch
17 times, most recently
from
b804554 to
ee806b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As refferenced on Winetricks#1344
making a new wineprefix is creating conflicts for installers that are
using custom WINE, this resolves it and seems to fix
Winetricks#599 as well.
Adding
winetricks_set_wineprefixto some verbs might be required, sofar no conflicts on WINE 4.17 packaged by Debian.
Fixes: Winetricks#1344
Fixes: Winetricks#1335
Fixes: Winetricks#1347
Allows adaptation using:
Winetricks#1348
Transfered from Winetricks#1359, will be remade once finished
Signed-off-by: Jacob Hrbek kreyren@rixotstudio.cz