Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create kratos docker #6515

Merged
merged 11 commits into from
Mar 13, 2020
Merged

Create kratos docker #6515

merged 11 commits into from
Mar 13, 2020

Conversation

philbucher
Copy link
Member

this creates a docker-image with a compiled Kratos

Can be very useful e.g. for other CIs (e.g. GiDInterface)

@philbucher philbucher requested a review from roigcarlo March 4, 2020 15:44
@philbucher philbucher marked this pull request as ready for review March 4, 2020 15:44
@philbucher
Copy link
Member Author

should work now once, jut needs to finish compiling :)

What do you think @roigcarlo ?

@roigcarlo
Copy link
Member

@RiccardoRossi will be superhappy to see this 😄

@philbucher
Copy link
Member Author

@RiccardoRossi will be superhappy to see this smile

Why? :)

@philbucher philbucher requested a review from RiccardoRossi March 4, 2020 16:32
@philbucher
Copy link
Member Author

The image with everything has 1.72 GB

@roigcarlo
Copy link
Member

He always wanted that :D

@philbucher
Copy link
Member Author

ah

well, he can have it if he approves ;)

@oberbichler
Copy link
Contributor

Maybe we should also build the releases (-> label) and specify runkratos as entrypoint.

@philbucher
Copy link
Member Author

Maybe we should also build the releases (-> label) and specify runkratos as entrypoint.

Sounds good
Although I am not sure if we can/should use runkratos. Firstly bcs it is not needed as second bcs I am not even sure it works with MPI

@armingeiser
Copy link
Member

Although I am not sure if we can/should use runkratos

I would say if possible use python directly.

@philbucher
Copy link
Member Author

The more I think abt this image, the more things that we can do with it come to my mind
Stay tuned :D

@loumalouomega
Copy link
Member

The more I think abt this image, the more things that we can do with it come to my mind
Stay tuned :D

I would like to create Jupyuter notebooks with binder, https://mybinder.org/, so we can introduce and present Kratos more easily

@oberbichler
Copy link
Contributor

I thought runkratos was the usual procedure :)

Something like docker run kratos:v7 main.py would be nice (I know. The command has to be longer at the end...).

@loumalouomega My personal experience: with binder the loading time is endless. Usually pip packages are the better choice for this kind of tasks.

@philbucher
Copy link
Member Author

Something like docker run kratos:v7 main.py would be nice (I know. The command has to be longer at the end...).

👍

@philbucher philbucher added this to the Release 8.0 milestone Mar 6, 2020
@philbucher
Copy link
Member Author

Does anyone have more comments or can we merge this?
I would like to use it myself right away and fix/update things if necessary

Copy link
Member

@roigcarlo roigcarlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me looks fine

@philbucher
Copy link
Member Author

Cool thx
Next step will be to use this image in the nightly build instead of re-building Kratos

@philbucher philbucher merged commit 27088c3 into master Mar 13, 2020
@philbucher philbucher deleted the create-kratos-docker branch March 13, 2020 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants