-
Notifications
You must be signed in to change notification settings - Fork 279
[Core][Future] Add linear system container #14161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rubenzorrilla
wants to merge
15
commits into
master
Choose a base branch
from
core/future-add-linear-system
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,400
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-add-linear-operators
…e-add-linear-operators
…e-add-linear-operators
Member
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR adds the
LinearSystemcontainer as well as anEigenvalueSystem. These are understood to be the containers that we pass to the corresponding linear solvers. TheLinearSystemcontainer is now fully operative in #14119 while theEigenvalueSystemis just a boilerplate I did to see how theLinearSolverinterface would be.Important details are:
EigenvalueSystem(and eventual alternative containers) do not derive fromLinearSystemas these may have different interfaces (e.g.,EigenvalueSystemhasGetMassMatrixandGetStiffnessMatrixmethods whileLinearSystemhasGetLeftHandSide). This implies that each linear solver knows how to use the corresponding container.LinearSolverbase class for all the different linear system container types.Finally, I note that instead of one for all design (i.e., a container suitable for standard Ax=b problems, eigenvalue, etc.), which would lead to a more complex usage IMO, I finally decided to have an easy-to-use one for the different cases after the assumption that we will need very few types these. In these regard, the applications I see are standard Ax=b problems, AX=B (i.e., multiple RHS) and eigenvalue analysis.
EDIT: #14110 must be merged first.