Skip to content

Commit

Permalink
minor change in deps and fix failing test
Browse files Browse the repository at this point in the history
  • Loading branch information
Krande committed Sep 13, 2023
1 parent 25afe8d commit 5d87238
Show file tree
Hide file tree
Showing 7 changed files with 5 additions and 240 deletions.
1 change: 0 additions & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ jobs:
pyparsing
websockets
pygfx
glfw
pyglfw
- name: Install latest adapy
Expand Down
1 change: 0 additions & 1 deletion conda/environment.full.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ dependencies:
- jupyterlab
- pythreejs
- pyparsing
- glfw
- pyglfw
- pygfx
- websockets
2 changes: 1 addition & 1 deletion src/ada/api/spatial/assembly.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def __init__(
name="Ada",
project="AdaProject",
user: User = User(),
schema="IFC4X3",
schema="IFC4X1",
settings=Settings(),
metadata=None,
units: Units | str = Units.M,
Expand Down
2 changes: 1 addition & 1 deletion tests/core/api/pipes/test_stru_pipes.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def test_pipe_multiple_bends(pipe_w_multiple_bends):


def test_write_elbow_revolved_solid_ifc_gen(pipe_w_multiple_bends):
a = Assembly("MyTest", schema="IFC4x3") / (Part("MyPart") / pipe_w_multiple_bends)
a = Assembly("MyTest", schema="IFC4x1") / (Part("MyPart") / pipe_w_multiple_bends)
a.ifc_store.sync()
# a.to_ifc('temp/pipes.ifc', file_obj_only=True, validate=True)
f = a.ifc_store.f
Expand Down
2 changes: 1 addition & 1 deletion tests/core/api/test_penetrations.py
Original file line number Diff line number Diff line change
Expand Up @@ -95,5 +95,5 @@ def test_poly_revolve():

bm.add_boolean(PrimRevolve("my_pen_revolved", points2d, rev_angle, origin, xdir, normal))

a.to_stp(test_dir / "penetrations_revolve.stp")
# a.to_stp(test_dir / "penetrations_revolve.stp")
_ = a.to_ifc(test_dir / "penetrations_revolve.ifc", file_obj_only=True)
233 changes: 0 additions & 233 deletions tests/core/cadit/sat/curved_plate.sat

This file was deleted.

4 changes: 2 additions & 2 deletions tests/core/cadit/sat/test_read_curved_plate_def.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
from ada.cadit.ifc.store import IfcStore


def test_read_a_curved_plate():
sat_reader = SatReaderFactory('curved_plate.sat')
def test_read_a_curved_plate(example_files):
sat_reader = SatReaderFactory(example_files / 'sat_files/curved_plate.sat')
bsplines = list(sat_reader.iter_bspline_objects())
assert len(bsplines) == 1

Expand Down

0 comments on commit 5d87238

Please sign in to comment.