Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill the name of the SecretListEntry from the GetSecretValueResponse #54

Merged
merged 1 commit into from
May 19, 2021
Merged

Fill the name of the SecretListEntry from the GetSecretValueResponse #54

merged 1 commit into from
May 19, 2021

Conversation

ycherkes
Copy link
Contributor

@ycherkes ycherkes commented May 5, 2021

Closes #53

@Kralizek
Copy link
Owner

Kralizek commented May 6, 2021

Hi @ycherkes
Thanks for your prompt PR to address #53 .

Could you please run something like the snippet below to show how the items are added to the configuration system?

void Main()
{
	var configuration = new ConfigurationBuilder().AddSecretsManager(o => o.AcceptedSecretArns = new[]{ "ARN", "ARN" }).Build();
	
	foreach (var item in configuration.AsEnumerable())
	{
		Console.WriteLine($"{item.Key} = '## SECRET VALUE ##'");
	}
}

Just to make sure that this is the intended output :)

@Kralizek Kralizek self-requested a review May 6, 2021 14:54
@icodev-space
Copy link

Hello guys, any update here?

@Kralizek
Copy link
Owner

@H1ndo sorry but at the moment I don't have capacity left for OSS development :(

@ycherkes
Copy link
Contributor Author

Hi @ycherkes
Thanks for your prompt PR to address #53 .

Could you please run something like the snippet below to show how the items are added to the configuration system?

void Main()
{
	var configuration = new ConfigurationBuilder().AddSecretsManager(o => o.AcceptedSecretArns = new[]{ "ARN", "ARN" }).Build();
	
	foreach (var item in configuration.AsEnumerable())
	{
		Console.WriteLine($"{item.Key} = '## SECRET VALUE ##'");
	}
}

Just to make sure that this is the intended output :)

Hi, I'm sorry for the late response.

It adds the "secretName" key for the ARN like this "arn:aws:secretsmanager:us-west-2:123456789012:secret:secretName-1cb5tT".

-- OUTPUT

secretName = '## SECRET VALUE ##'

@icodev-space
Copy link

Would bribing with cookies help here? :)

@Kralizek
Copy link
Owner

Would bribing with cookies help here? :)

Ouch sorry! I was hoping to get this done during the weekend. I'll try to fix it tomorrow during the lunch break 😅

@Kralizek Kralizek merged commit 7a2dd15 into Kralizek:master May 19, 2021
@Kralizek
Copy link
Owner

Merged, thanks to @ycherkes for fixing this one and sorry for those who waited so long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sanitize secrets' names when using AddSecretsManager's AcceptedSecretArns option
3 participants