Use favicon as default link icon if present #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kovah
requested changes
Sep 16, 2024
There was a problem hiding this comment.
Hi, thanks for taking care of this feature.
The current implementation seems to do a HEAD request on the favicon every time the link icon should be rendered. This would mean that on a link list with 50 links, LinkAce would do 50 HTTP requests for the favicon alone. Is that correct?
|
Ping @Otanga-Otieno |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update adds functionality to check if a link has a favicon. If a favicon is present, it will be used as the link icon. If not, the default link icon will be used.
This attempts to fix issue 302