Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link Sharing: Toggle All On/Off Toggles Individual States Not All Services #581

Closed
BrookeDot opened this issue Nov 29, 2022 · 1 comment · Fixed by #585
Closed

Link Sharing: Toggle All On/Off Toggles Individual States Not All Services #581

BrookeDot opened this issue Nov 29, 2022 · 1 comment · Fixed by #585
Labels
Bug Something isn't working

Comments

@BrookeDot
Copy link

BrookeDot commented Nov 29, 2022

Bug Description

When using the "Toggle all on/off" link when some services are enabled the state of those services changes to "off" with the rest of the services toggling to "on". The expected behavior would be that all services get toggled to the opposite state and if services are already selected (enabled) they are toggled off.

How to reproduce

  1. Go to example.com/settings/system
  2. Scroll to "Link Sharing"
  3. Enable some sharing services
  4. Select "Toggle all on/off"
  5. Note that the individual services' state is toggled, not all services

This can also be seen in the demo

Expected behavior

The expected behavior would be that all services get toggled to the opposite state and if services are already selected (enabled) they are toggled off.

Logs

No response

Screenshots

Screen.Recording.2022-11-28.at.3.45.42.PM.mov

LinkAce version

v1.10.5

Setup Method

PHP

Operating System

Linux (Ubuntu, CentOS,...)

Client details

No response

@BrookeDot BrookeDot added the Bug Something isn't working label Nov 29, 2022
@Kovah
Copy link
Owner

Kovah commented Nov 29, 2022

Thank you very much for the report. Definitely not working as expected.

Kovah added a commit that referenced this issue Dec 14, 2022
@Kovah Kovah linked a pull request Dec 15, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
Status: Released
Development

Successfully merging a pull request may close this issue.

2 participants