Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2FA: Scanning the QR-Code doesn't work #501

Closed
tohn opened this issue Jul 3, 2022 · 5 comments
Closed

2FA: Scanning the QR-Code doesn't work #501

tohn opened this issue Jul 3, 2022 · 5 comments
Labels
Bug Something isn't working

Comments

@tohn
Copy link

tohn commented Jul 3, 2022

Describe the bug
I can't seem to scan the (SVG-)QR-Code when enabling 2FA.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://linkace.example/settings
  2. Click on 'Enable Two Factor Authentication'
  3. Scan the QR-Code with an app (I tried with Aegis and Binary Eye)
  4. Nothing happens

Expected behavior
When scanning the QR-Code, the (Android) App should react.

Screenshots
Sorry, I can't publish my QR-Code here 😉

LinkAce setup (please complete the following information):

  • Version: v1.10.2
  • Installed via: Docker
  • OS: ArchLinux

Desktop (please complete the following information if applicable):

  • OS: macOS 12.4
  • Browser: Vivaldi
  • Version: 5.3.2679.61

Smartphone (please complete the following information if applicable):

  • Device: Xiaomi Redmi Note 7 Pro
  • OS: Android

Additional context
When taking the provided alternative link and generating a QR-Code with this, the output looks different, but it works in Aegis and BinaryEye (even this "picture" below should work):

echo -n "otpauth://totp/LinkAce:mail%40linkace.example?secret=DJQ86QAQ1RLLINKA&issuer=LinkAce&algorithm=SHA1&digits=6&period=30" | qrencode -tutf8
█████████████████████████████████████████████████
█████████████████████████████████████████████████
████ ▄▄▄▄▄ █▀ ██▄ ▀██▄ ▄ ██▄▀█▄▀▀▀ ▄▄█ ▄▄▄▄▄ ████
████ █   █ █▀▀█ █▄▀  █ █  ▄ █▄█ ▄ ▀  █ █   █ ████
████ █▄▄▄█ █▀ █▀███ ▀▀ ▀▀  ▀ █ ▀█ ▀▄██ █▄▄▄█ ████
████▄▄▄▄▄▄▄█▄▀▄▀ ▀▄▀▄█▄█▄▀ ▀▄█▄▀ █▄▀ █▄▄▄▄▄▄▄████
████▄   ▄█▄  ▄▄█▀▄▄ ▀▄█ ▀▀    ▀▄██▀▀▀▄▀ ▀▄█▄▀████
████▀█▀█▄ ▄█▀ █▀▀█▀▄▄█ ▀▄▀▀██▀█ ▀ ██▄█▀ █▀█▄▄████
████▀▀▀█▄▄▄▀██ ▄▄▀▀ ▀█ █▄█▀█▀█▀██▄▄ ▄▄▀▄██ ▄ ████
█████ ▀▄▄▄▄██▀  ▄▄▄█▀▄  ▀ █▄▀██▀▄█▄▄█▀█▀ ▄▀▀█████
████▀ ▄  ▀▄ █▀▄▄▀▀█▀▄ ▀  █▄ ▄▄▄█▀ ▀▀▀▀▀█▀▄▄█▀████
██████▀▄  ▄▄█▄▀▀  ▄▀▀ ▀▀  █▀▀▄▀ ▄█▄█▀██ █ █ ▄████
█████▄█  ▀▄▄▄▄▄█▀█▄▀▄█▀▄▄▀▀▀▀ ▀██▄▄ ▄  ▄▀▄ █▀████
█████▄█ ▄ ▄▀  ██▀▀▄ ▄██▀█ ▀▀ █▄█▀▄▄▀▄█ ▀▀█ █▀████
████▄█▄▀▄█▄ ▄▀▄▀███  ▄█▀▄▀▄ ▄▄▄█▀▄▀█▀█▀█▀ ▄█ ████
████▀▄▀▄▄▀▄▀▄█▄█▄█▀▄██▄█ ███▀▄█ ▄▀▀▀  ███ █▄▀████
████ █▀▀█▄▄   ▀▄▄█▀ ▀█▄▀▄█▀▀▀ ▀ ▄▄▄▄▄▄ ██▄▄ ▀████
████ █ ▄▄█▄▄ ▀▀ ▄  █▀█▀    ▄▄█▀█▀██ █▀█▀██ ██████
████▄██▄▄▄▄▄▀ ▀▄█▀█▀█ ▄▀▀█ ▀▄▄▄▄▀ ▄█ ▄▄▄  ▄██████
████ ▄▄▄▄▄ █▄▀▀█  ▄▀█ ▀█▀ ▀▀▀▀▄  ▄ ▄ █▄█ ▀█ ▄████
████ █   █ █ ▄ █▀▀▄ ▄▀▀ ▄▀▀ ▀ ▀█▄ ▄█▄▄▄ ▄█ ▄ ████
████ █▄▄▄█ █  ▄█▀▀▄ ▄██▄▀ █ ▀▄▄ ▀▄ ▀▀▀▄█ ▄█ █████
████▄▄▄▄▄▄▄█▄▄████▄▄█▄▄███▄█▄▄▄▄█▄██▄████▄███████
█████████████████████████████████████████████████
█████████████████████████████████████████████████
@tohn tohn added the Bug Something isn't working label Jul 3, 2022
@Kovah
Copy link
Owner

Kovah commented Jul 3, 2022

Thanks for the detailed report, will have a look as soon as possible.

@Kovah
Copy link
Owner

Kovah commented Nov 17, 2022

I am not sure about the apps you used, but the QR code seems to be generated as expected in version 1.10.4.

  1. I enabled 2FA in the user settings, the QR code represented otpauth://totp/LinkAce:linkace%40example.com?secret=QMXVOB4SG2HLUTMI&issuer=LinkAce&algorithm=SHA1&digits=6&period=30 which is exactly what was displayed below.
  2. I scanned the code with Duo, it successfully added the account and generates codes.
  3. After logging out, I logged back in, using the code generated by Duo.

@Kovah Kovah added the awaiting Response Issue is awaiting response for a long time already. label Nov 17, 2022
@tohn
Copy link
Author

tohn commented Nov 17, 2022

I think I figured it out: it's the dark mode I was using. Apparently the QR Code needs a small white border around the code to work. If I'm using light mode, it works instantaneously.

This works:

Screenshot 2022-11-17 at 21 02 09

This doesn't work:

Screenshot 2022-11-17 at 21 02 48

@Kovah
Copy link
Owner

Kovah commented Nov 17, 2022

Interesting, that's a good point. Will try that out and add a border for the code.

@Kovah Kovah removed the awaiting Response Issue is awaiting response for a long time already. label Nov 17, 2022
@Kovah
Copy link
Owner

Kovah commented Dec 15, 2022

Border was added, should be working now in dark mode.

@Kovah Kovah closed this as completed Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
Status: Released
Development

No branches or pull requests

2 participants