[Features] Collaborations #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Koustubh Karmalkar <koustubh_karmalkar@persistent.com>
Signed-off-by: Koustubh Karmalkar <koustubh_karmalkar@persistent.com>
Signed-off-by: Koustubh Karmalkar <koustubh_karmalkar@persistent.com>
Signed-off-by: Koustubh Karmalkar <koustubh_karmalkar@persistent.com>
Signed-off-by: Koustubh Karmalkar <koustubh_karmalkar@persistent.com>
…ervability into features/collaborations
Signed-off-by: Koustubh Karmalkar <koustubh_karmalkar@persistent.com>
abasatwar
suggested changes
Sep 16, 2022
|
|
||
| .count-badge { | ||
| position: absolute; | ||
| margin-left: -15px; |
There was a problem hiding this comment.
Negative value is required to place the badge on top of the button
dashboards-observability/public/components/custom_panels/collaboration/collaboration.tsx
Outdated
Show resolved
Hide resolved
dashboards-observability/public/components/custom_panels/collaboration/collaboration.tsx
Outdated
Show resolved
Hide resolved
dashboards-observability/public/components/custom_panels/collaboration/collaboration.tsx
Outdated
Show resolved
Hide resolved
dashboards-observability/public/components/custom_panels/collaboration/collaboration.tsx
Outdated
Show resolved
Hide resolved
| /> | ||
| } | ||
| isOpen={selectedIndex === index} | ||
| closePopover={() => setSelectedIndex(-1)} |
There was a problem hiding this comment.
If we use 0 here then by default context menu of 1st item gets open. Hence used -ve value.
dashboards-observability/public/components/custom_panels/custom_panel_view.tsx
Outdated
Show resolved
Hide resolved
dashboards-observability/public/components/custom_panels/custom_panel_view.tsx
Outdated
Show resolved
Hide resolved
dashboards-observability/public/components/custom_panels/collaboration/collaboration.tsx
Outdated
Show resolved
Hide resolved
...anel_modules/visualization_flyout/__tests__/__snapshots__/visualization_flyout.test.tsx.snap
Outdated
Show resolved
Hide resolved
Signed-off-by: Koustubh Karmalkar <koustubh_karmalkar@persistent.com>
Signed-off-by: Koustubh Karmalkar <koustubh_karmalkar@persistent.com>
Signed-off-by: Koustubh Karmalkar <koustubh_karmalkar@persistent.com>
Signed-off-by: Koustubh Karmalkar <koustubh_karmalkar@persistent.com>
Signed-off-by: Koustubh Karmalkar <koustubh_karmalkar@persistent.com>
Signed-off-by: Koustubh Karmalkar <koustubh_karmalkar@persistent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On the event of spikes or anomalies, users can add insights (e.g “spike in metrics here is due to ....), so the team can collaborate and comment to resolve the issue. Implemented the static UI flow.
Issues Resolved
opensearch-project/dashboards-observability#136
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.