[API stabilization] SerialDescriptorBuilder #903
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
qwwdfsad
commented
Jul 13, 2020
qwwdfsad
commented
* Rename file to SerialDescriptors
* Provide top-level factotires and typeOf API
* Consistent future-proof naming of builders that allows to easily add new builders in the future
* Remove builder with an arbitrary kind as too error-prone and incorrect anyway
sandwwraith
reviewed
Jul 13, 2020
runtime/commonMain/src/kotlinx/serialization/descriptors/SerialDescriptors.kt
Show resolved
Hide resolved
runtime/commonMain/src/kotlinx/serialization/internal/CollectionSerializers.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.