Use @PublishedApi annotation on functions called from plugin-generated code #2705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d code Since these functions can be called from other modules, they should have this annotation to satisfy a compiler visibility checker. Fixes #2703
Important note: not just for that, but because these functions are effectively public ABI, but nothing in their signature indicated that they are, and that they should be maintained as such. |
shanshin
approved these changes
Jun 5, 2024
|
@sandwwraith , api check failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since these functions can be called from other modules, they should have this annotation to satisfy a compiler visibility checker.
Fixes #2703